Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tile): remove double border fix #9485

Merged
merged 2 commits into from
Aug 19, 2021
Merged

fix(Tile): remove double border fix #9485

merged 2 commits into from
Aug 19, 2021

Conversation

tw15egan
Copy link
Collaborator

Closes #8523

This removes the double border fix that was removed in #8529 but added back in #9067

Changelog

Removed

  • Invalid "double border" fix

Testing / Reviewing

Ensure that all borders are present when multiple selectable tiles are selected

@tw15egan tw15egan requested a review from a team as a code owner August 17, 2021 12:08
@tw15egan tw15egan requested review from joshblack and dakahn August 17, 2021 12:08
@netlify
Copy link

netlify bot commented Aug 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 0ea73cf

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/611e24ff107d62000739125b

😎 Browse the preview: https://deploy-preview-9485--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 0ea73cf

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/611e24ffbe77df0007504a70

😎 Browse the preview: https://deploy-preview-9485--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0ea73cf

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/611e24ffbfe08b0008307556

😎 Browse the preview: https://deploy-preview-9485--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

@tw15egan for fixes like this, do you think it'd be better to try and pair up the fixes in @carbon/styles or just wait and sync all of the files closer to release?

@tw15egan
Copy link
Collaborator Author

@joshblack for any style fixes I've been making the same changes in @carbon/styles, it seems like this one was already fixed there and must have been changed between the revert 👍🏻

@joshblack
Copy link
Contributor

Oh perfect, makes sense!

@kodiakhq kodiakhq bot merged commit 5d97c24 into carbon-design-system:main Aug 19, 2021
@joshblack joshblack mentioned this pull request Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tile: Visual regression for selectable tiles
3 participants
@tw15egan @joshblack @dakahn